search

nomovok-opensource / cutedriver-agent_qt

Other
6 stars 12 forks source link

qjson doesnt compile with qt5 #24

Closed rasjani closed 6 years ago

rasjani commented 7 years ago

On platforms where qjson is being compiled - agent_qt compilation fails as qjson uses QString.toAscii() which has been deprecated.

I'll fix this but need a pointer should i just copy over the qjson from upstream or use it as submodule or can it be just removed ?

jppiiroinen commented 7 years ago

Just checked the 3rdparty/qjson which seems to be 6 years old and that is only active for win32, which I have not personally used for compiling for awhile.

As far as I know, the qjson module has been part of the official Qt5 tree for few years, which would speak on the behalf of removing the qjson itself from this source tree and use the official Qt5 json related module instead.

Feel free to do a pull request, where the qjson module is removed.