search

nomovok-opensource / cutedriver-agent_qt

Other
6 stars 12 forks source link

Fixed issue #31: Added support for port configuration #32

Closed jppiiroinen closed 6 years ago

jppiiroinen commented 6 years ago

Environment variables: QTTASSERVER_HOST_BINDING QTTASSERVER_HOST_PORT

Configuration file properties: hostBinding hostPort

Where the hostBinding was already existing, updated also the default qt_testability.ini file to include these.

rasjani commented 6 years ago

Just fyi - i do have some patches - half done - that will also allow setting up these (and also hardcoded file locations) via qmake before compiliation.

jppiiroinen commented 6 years ago

feel free to contribute, we needed these for a project in which we use cutedriver asap. :) ..you can create tickets and comment then there when you have started to work on something, this way we dont do duplicate work either. And what comes to this PR and your upcoming one, I don't have personal preference if you like to make the code look better. I tried to keep the same code style which the files had. I have on my todo list to update the cutedriver-examples to have tests for these env flags.

rasjani commented 6 years ago

Well, the issue is, i already started to work on it long time ago but cleanup took a while to land and most of the stuff i already forgot :D but yeah, i just wanted to say that i do have some stuff done and if it helps -- stuff is currently in my fork in "optimize-parallel-builds" branch, which "also" allows parallel building (make -jX style)

jppiiroinen commented 6 years ago

do you want to do a rebase and a pull request for those?

I saw at least these two commits: https://github.com/rasjani/cutedriver-agent_qt/commit/5f998b815400f624bf43acae9dc3bc3aa262711a https://github.com/rasjani/cutedriver-agent_qt/commit/15914b339d0a9e06c9d094b527aa6484179092dc