nomovok-opensource / cutedriver-agent_qt

Other
6 stars 12 forks source link

Remove config+=ordered to allow parallel building #44

Closed rasjani closed 6 years ago

rasjani commented 6 years ago

Also speed up travis build by providing -j2

jppiiroinen commented 6 years ago

Added code review comments, where one is a bug which needs to be fixed.

jppiiroinen commented 6 years ago

The code compiling time with "make -j" results.

Before: real 1m8.019s user 4m39.760s sys 0m36.408s

After: real 0m32.798s user 4m49.116s sys 0m36.468s

rasjani commented 6 years ago

Cant see any other comments beside the compilation time comparison

jppiiroinen commented 6 years ago

Sorry forgot to "push button" on the review tab..