search

non / alleycats

Cats instances and classes which are outlaws, miscreants, and ne'er-do-wells.
Other
62 stars 14 forks source link

Fix #7: Add Scala.js support #10

Closed ghost closed 8 years ago

ghost commented 8 years ago

also Fix #8

non commented 8 years ago

Thanks! Looks like there are some compilation errors.

ghost commented 8 years ago

@non Until the corresponding PR in cats is released, this will not compile. ie https://github.com/non/cats/pull/495

And even then, note that the dependency is on a Cats snapshot.

non commented 8 years ago

Unfortunately I failed to merge the future support in Cats before releasing 0.2.0, so this will need to wait until we have a working snapshot there.

non commented 8 years ago

One other consideration: given that we are likely going to be moving the Await / j.u.c support into cats.jvm, would you rather move this stuff into cats.js? I'm fine with leaving it in Alleycats, but it seems like it might make life a lot easier for us to put it there instead.

ghost commented 8 years ago

@non Given that the cats layout is going to change, both https://github.com/non/cats/pull/495 and this PR need a major refactor regardless.

But I also agree that it's better to move to cats, at least for the short/middle term and pre cats 1.0. But it was good to try out this route, just to see the benefits/drawbacks.

So I will close this PR.