Open mdedetrich opened 6 years ago
Bump! I'd love to try this as well.
@prurph You can check out https://github.com/mdedetrich/cats-check
Hi @non , @mdedetrich ,
There was a casual comment made on gitter that perhaps this library should be moved (somewhere) into cats. Would this make sense to you guys? It‘s not my project to give away, nor is cats mine to accept it, and I‘ve not looked at what extra may be needed, etc.... I‘m just getting the ball rolling,
Personally, it sounds more a module in ScalaCheck than in cats. I am curious how @rickynils sees this.
But there is the the cats dependency, so that would be circular. If I understand it correctly, the scalacheck namespace is only because of the private namespace.
Ah.. I thought it might be okay since it's only circular at project level but not at the module (jar) level. Will it be still problematic even if cats does not depend on this module?
https://github.com/non/cats-check/blob/master/src/main/scala/catscheck/instances/cogen.scala#L50 Is the problem, for example. The Eq methods could go to scalacheck, then we just have the few extra methods in cats
in https://github.com/rickynils/scalacheck/issues/351#issuecomment-322763942, @rickynils mentions keeping „core“ small, but one could easily argue that the two Eq methods are generic.
I am happy to move this into cats, one less thing for me to maintain ;)
And yes there is a bit of a circular dependency because of needing the private namespace.
It seems that cats-check hasn't actually be released? Also it might be better to change
.settings(name := "catsCheck")
to.settings(name := "cats-check")
.