search

nonchris / discord-fury

Customizable discord bot for voice channels on demand and breakout rooms
GNU General Public License v3.0
12 stars 7 forks source link

↗️ Improved compatibilty with newer python versions #13

Closed MayNiklas closed 4 years ago

MayNiklas commented 4 years ago

At the moment, we are using a Debian base image for the docker container. For this reason, we only can install python versions via apt, which are already in the Debian repositories. We COULD compile newer python versions manually into our Debian based image, but this would lead into a bigger image size and a more complicated Dockerfile which would be harder to maintain. We weren't able to switch to the Python base image before, since Docker build was't able to build it for ARM platforms.

This is why I suggest the following changes:

I'm still building the 3 images in 3 jobs -> faster build process. We could use "docker buildx build --platform linux/amd64,linux/arm64,linux/arm/v7", but I wouldn't recommend it for obvious performance reasons.

The build process was already tested within a test repository, everything should work first try (please don't quote me on that later :D).

Docker buildx is a quemu based experimental feature. But in my experience, it's working perfectly fine for over a year at this point.

nonchris commented 4 years ago

Sound like a great enhancement of the docker environment! Thanks for your contribution.