search

nondanee / vsc-netease-music

UNOFFICIAL Netease Music extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=nondanee.vsc-netease-music
MIT License
1.02k stars 79 forks source link

fix webview html content (not working on vsc-insider on electron 3.1.8) #41

Closed asahui closed 5 years ago

asahui commented 5 years ago

extension works on vsc

Version: 1.33.1 (user setup) Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8 Date: 2019-04-11T08:27:14.102Z Electron: 3.1.6 Chrome: 66.0.3359.181 Node.js: 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0.17134

But it is not working on vsc-insider

Tested Version: Version: 1.34.0-insider (user setup) Commit: 6d5feae57959287fb116467f4eb6c7079571b466 Date: 2019-04-17T09:25:49.535Z Electron: 3.1.8 Chrome: 66.0.3359.181 Node.js: 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0.17134

According to VSCode API, Webview.html is a string. readFileAsync returns a Buffer if encoding is not set. Tested on vsc, set webview.html to a Buffer is working but it does not work on vsc-insider. I guess it may be relevant to the electron upgrade.