PR: Do you like music visualization?

nondanee / vsc-netease-music

UNOFFICIAL Netease Music extension for Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=nondanee.vsc-netease-music

MIT License

1.02k stars 79 forks source link

PR: Do you like music visualization? #63

Closed alex2wong closed 5 years ago

alex2wong commented 5 years ago

Thank you for providing such good extension~~ I suppose we can add some more feature like music visualization. I've made one yesterday, tested locally. If you think it is OK, I'd like to send a PR.

snapshot as follows: vscode_vudio

Technically, vudio.js was imported for audio visualization. Current issue is that I can NOT get song cover from existing request API, could you guys just add a cover img url attr for song API ? then I can rotate it in the circular : )

nondanee commented 5 years ago

Related issue #56 Honestly, I have no plan to add UI elements to webview page Thanks, anyway You can package your customized version to .vsix and install for personal use

Cover img url will be added to song object very soon : )

alex2wong commented 5 years ago

Sure, thanks a lot : ) Actually this kind of feature can be optional, user can enable/disable it by controllers or keyboard shortcut. It cost some GPU/memory resource indeed and can attract unnecessary attention.

Looking forward the cover img url, thanks again.