search

nondanee / vsc-netease-music

UNOFFICIAL Netease Music extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=nondanee.vsc-netease-music
MIT License
1.02k stars 80 forks source link

vscode 1.43.1 macOS not load vsc-netease #87

Closed diegofn closed 4 years ago

diegofn commented 4 years ago

Hello,

Screen Shot 2020-03-22 at 10 08 11 AM

I have vscode 1.43.1 on Catalina macOS. This version already include the libffmpeg.dylib but I get the following error when I trying the load the netease extension.

I run the script to copy the libffmpeg version from electron and I receive the same error. I install vscode 1.36.1, install the extension and I get the same error.

Is there any way to get your help.

Thanks for all.

nondanee commented 4 years ago

Any version of VS Code include libffmpeg.dylib You can regard it as a "placeholder"

VS Code 1.43.x will crash at start after lib replacement #86 The error log shows EXC_BAD_ACCESS (Code Signature Invalid) You can turn off SIP (System Integrity Protection) if you have urgent need with this extension

In short, VS Code Webview can not play audio anymore after 1.43.x I will change the implement for macOS as soon as possible

The extension should be worked in 1.36.1, but still need replacing ffmpeg lib

diegofn commented 4 years ago

Thanks for your help. I will wait for a new version.

undefined-moe commented 4 years ago

The same problem.

xiaoweiz commented 4 years ago

Running the script to do the automatic replacement will lead to crash on my machine, exactly as reported. However, I went to the Electron repository to download the proper release version and did a manual replacement of the libffmpeg.dylib file. It then worked.

I'm not sure the reason, but hope this info can be of help.

nondanee commented 4 years ago

@xiaoweiz So what is "the proper release version" ? The automatic script use the electron mirror from taobao npm instead of official repository I will check it soon THX

xiaoweiz commented 4 years ago

The version indicated by the script, e.g. electron 7.1.1 for vscode 1.43.3

nondanee commented 4 years ago

@xiaoweiz Thank you for your feedback The automatic script use shutil.copyfileobj for file replacement https://stackoverflow.com/a/30359308 Because shutil.copyfileobj can not overwrite metadata, maybe the mismatched metadata cause crash I update script and add os.remove to ensure the whole file can be replaced completely

You can continue using the automatic replacement It should work now

diegofn commented 4 years ago

Hello, Its works for me. Thank you  :-)