search

nonrnp / pe

0 stars 0 forks source link

Incorrect sequence diagram in `MainParser` #12

Open nonrnp opened 2 years ago

nonrnp commented 2 years ago

image.png

I think there should be a return to the MainParser itself once before :Command can be returned outside.

nus-se-bot commented 2 years ago

Team's Response

According to the lecture notes, the lack of the return arrow does not result in ambiguities or loss of relevant information. It is clear a command is still being returned.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This bug still cause a confusion to the reader. According to the diagram, there is no way to tell if the return :Command is returned from the main activation bar or the self-invoked bar since both of them end at the exact point. If the returned :Command is from the main bar, then the self-invoked bar should end before the return arrow, but if :Command is returned from the self-invoked bar, then the main activation bar has to end after the return arrow.