search

nonsequitur / git-gutter-plus

147 stars 18 forks source link

Why should I use this instead of the original git-gutter.el? #11

Closed tarsius closed 9 years ago

tarsius commented 10 years ago

The readme sais:

It contains patches that haven't yet been added to Git-Gutter.

That's a bit vague.

Does it have additional features? (If so, which and does it also lack features?) Or does it just implement some things more cleanly? (If so, why was it still necessary to fork?)

Also the yet implies that this will be merged eventually; it doesn't really look like that is ever going to happen.

git-gutter seems to be more actively maintained than git-gutter+. Do you intend to incorporate changes into your fork and just didn't get to it yet? Or do you think git-gutter is headed into the wrong direction?

These questions should be answered in the readme. If you don't do that then every users has to either randomly pick one over the other, or manually compare the source code.

I had a quick look at https://github.com/syohex/emacs-git-gutter/pull/30. So at least initially the changes were:

To me it looks like this this fork exists mainly because @nonsequitur created a pull request that did to much and @syohex, instead of requesting that it be split up, just didn't do anything about it.

tarsius commented 10 years ago

@syohex Have these changes since made it into git-gutter? Why not?

syohex commented 10 years ago

These changes were not enough for my usecase. At that time, I had no ideas which fulfill my usecase with there changes.

nonsequitur commented 10 years ago

Does it have additional features?

First of all, staging and committing hunks. (Or hunk lines within the region.) To highlight this, I've added an animated GIF to the Readme.

It shouldn't be too hard to port this feature back to git-gutter. (But I don't have the time right now.)

syl20bnr commented 9 years ago

This is always sad when a contributor submit an atomic bomb PR which ends in a fork... in the end everybody looses.

@nonsequitur It is possible to stage hunk in git-gutter, spacemacs has bindings for it here: https://github.com/syl20bnr/spacemacs/blob/master/contrib/git/packages.el#L71

If you have not a lot of time, can you at least update the readme to be clear about the differences between this repo and the vanilla git-gutter. You added a + to your package name, please be more specific about it. Then someone else will know where to look if he/she wants to contribute back your exclusive feature to git-gutter. Thank you.