nonsequitur / git-gutter-plus

146 stars 17 forks source link

support refresh with newer versions of magit #27

Closed ajschumacher closed 8 years ago

ajschumacher commented 8 years ago

In newer versions of magit, there are a couple changes from older versions:

This pull request makes corresponding changes so that git-gutter+ refreshes appropriately when using new versions of magit, and shouldn't break the same behavior even with older versions of magit.

My tweaked version is working for me - let me know if this will work merged in here! Thanks for the great tool!

mtoossi commented 8 years ago

Was going to make the exact same pull request before I saw this. Please accept this pull request.

magit-refresh-status-hook was removed from magit in Jan 2015 : magit/magit@f38e03f94dd4a7964c828898a67bd6411d311200

mtoossi commented 8 years ago

Actually, I just noticed that you're using magit-refresh-buffer-hook. From the commit I linked above, it looks like magit-status-refresh-hook is the correct replacement for the old magit-refresh-status-hook.

ajschumacher commented 8 years ago

Thanks @khorkhov! I updated as you suggested; it's working well for me! :+1:

mtoossi commented 8 years ago

@ajschumacher: Thanks for updating, I've tested it as well and works for me too.

nonsequitur commented 8 years ago

Commited at https://github.com/nonsequitur/git-gutter-plus/commit/b7726997806d9a2da9fe84ff00ecf21d62b6f975, thanks!