Derive `inf-ruby-mode` from comint-mode

nonsequitur / inf-ruby

218 stars 69 forks source link

Derive `inf-ruby-mode` from comint-mode #53

Closed bbatsov closed 8 years ago

bbatsov commented 10 years ago

I noticed inf-ruby-mode doesn't derive from comint-mode. Is there any special reason for this or it's just a matter of legacy?

dgutov commented 10 years ago

The latter, I suppose (it calls comint-mode anyway).

If it becomes a derived mode, the trick with preserving the value of mode-line-process won't survive, but we can move it to inf-ruby-switch-from-compilation, similarly to inf-ruby-maybe-switch-to-compilation.