nonsequitur / inf-ruby

218 stars 69 forks source link

Apply `defcustom` fixes #54

Closed wasamasa closed 10 years ago

wasamasa commented 10 years ago

I find it weird that inf-ruby allows one to select the Ruby implementation interactively, yet it hasn't a defcustom form to choose the default Ruby implementation to fall back. Additionally to that I've added extra code to make customize construct a proper interface from the two forms used.

wasamasa commented 10 years ago

Perhaps add inf-ruby-implementations, too?

dgutov commented 10 years ago

Perhaps the possible values of inf-ruby-default-implementation should depend on the available keys in inf-ruby-implementations?

Perhaps add inf-ruby-implementations, too?

Maybe. It seems a bit more complicated, though.

wasamasa commented 10 years ago

This implements the first one, as for the second one, I'm less sure how one would fit that into customize.

dgutov commented 10 years ago

as for the second one, I'm less sure how one would fit that into customize

Check out http://www.gnu.org/software/emacs/manual/html_node/elisp/Composite-Types.html#Composite-Types

You should be able to combine :type, repeat, cons and string to make it work.

wasamasa commented 10 years ago

This should address the problem.

dgutov commented 10 years ago

Thanks!