search

nonsequitur / inf-ruby

218 stars 69 forks source link

Jump to end of buffer when switch from compilation #87

Open mkaschenko opened 8 years ago

mkaschenko commented 8 years ago

https://github.com/pezra/rspec-mode/issues/143#issuecomment-212206357

mkaschenko commented 8 years ago

While it works as expected when inf-ruby-switch-from-compilation is called interactively, it's a bit more tricky when if-ruby-switch-from-compilation is called within inf-ruby-auto-enter. The point is still in the beginning.

I think the reason for that is: rspec-mode/rspec-compile calls compile/compile which calls compilation-start. There is code inside compilation-start which pushes the point back to the top based on compilation-scroll-output variable.

dgutov commented 8 years ago

I think the reason for that is: rspec-mode/rspec-compile calls compile/compile which calls compilation-start. There is code inside compilation-start which pushes the point back to the top based on compilation-scroll-output variable.

Try (setq compilation-filter-start (point-max)) instead of (goto-char (point-max)), in inf-ruby-auto-enter.

If that doesn't work, replacing (inf-ruby-switch-from-compilation) with (run-with-idle-timer 0 nil #'inf-ruby-maybe-switch-from-compilation) should. But that's a bit uglier.

dgutov commented 8 years ago

@mkaschenko Please notify when it's ready to be merged. Looking at the current diff, it doesn't seem to address the problem you mentioned.

mkaschenko commented 8 years ago

It's not finished yet. I will notify.

On Aug 27, 2016, at 07:03, Dmitry Gutov notifications@github.com wrote:

@mkaschenko Please notify when it's ready to be merged. Looking at the current diff, it doesn't seem to address the problem you mentioned.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.