noobaa / noobaa-core

High-performance S3 application gateway to any backend - file / s3-compatible / multi-clouds / caching / replication ...
https://www.noobaa.io
Apache License 2.0
270 stars 80 forks source link

UI stuck on check when entering wrong secret when adding server to cluster #2731

Closed jackyalbo closed 7 years ago

jackyalbo commented 7 years ago

Environment info

Actual behavior

  1. Adding a new server to cluster in UI - with wrong secret - screen is showing loading screen - and never shows the failure of secrets don't match - seems like an rpc call error

Expected behavior

  1. checking should fail and tell the user what's wrong

Steps to reproduce

  1. add a server to cluster - enter a wrong secret

Screenshots or Logs or other output that would be helpful

from the server logs:

Feb 28 07:30:57 NooBaa05 WebServer[12712]:  [ERROR]  core.server.system_services.cluster_server:: Secrets do not match!
Feb 28 07:30:57 NooBaa05 WebServer[12712]:  [ERROR]  CONSOLE:: RPC._on_request: ERROR srv cluster_internal_api.verify_join_conditions reqid 4@wss://13.66.213.31:8443(289ol9z3y) connid ws://[::ffff:13.66.218.115]:35436/(jm10cvi8) TypeError: _verify_join_preconditons(.
..).then is not a function    at P.resolve.then.then.os_info (/root/node_modules/noobaa-core/src/server/system_services/cluster_server.js:232:18)    at tryCatcher (/root/node_modules/noobaa-core/node_modules/bluebird/js/release/util.js:16:23)    at Promise._settlePro
miseFromHandler (/root/node_modules/noobaa-core/node_modules/bluebird/js/release/promise.js:504:31)    at Promise._settlePromise (/root/node_modules/noobaa-core/node_modules/bluebird/js/release/promise.js:561:18)    at Promise._settlePromise0 (/root/node_modules/noob
aa-core/node_modules/bluebird/js/release/promise.js:606:10)    at Promise._settlePromises (/root/node_modules/noobaa-core/node_modules/bluebird/js/release/promise.js:685:18)    at Async._drainQueue (/root/node_modules/noobaa-core/node_modules/bluebird/js/release/asyn
c.js:138:16)    at Async._drainQueues (/root/node_modules/noobaa-core/node_modules/bluebird/js/release/async.js:148:10)    at Immediate.Async.drainQueues (/root/node_modules/noobaa-core/node_modules/bluebird/js/release/async.js:17:14)    at runCallback (timers.js:649
:20)    at tryOnImmediate (timers.js:622:5)    at processImmediate [as _immediateCallback] (timers.js:594:5)

noobaa_management_console

jackyalbo commented 7 years ago

you also can't continue even when you correct the secret - just moves the next left and right - but doesn't let the user know what's wrong