search

noobaa / noobaa-core

High-performance S3 application gateway to any backend - file / s3-compatible / multi-clouds / caching / replication ...
https://www.noobaa.io
Apache License 2.0
265 stars 78 forks source link

[native] noobaa-core container build is failing #7043

Closed nik-redhat closed 2 years ago

nik-redhat commented 2 years ago

Environment info

Actual behavior

  1. The container build of noobaa-core is failing on executing the command npm --nodedir=/usr run build:native

Expected behavior

  1. The command should succeed and the container should be built correctly.

Steps to reproduce

  1. Try creating a container using this Dockerfile

More information - Screenshots / Logs / Other output

Build logs can be found here

nik-redhat commented 2 years ago

The issue started happening after the PR #7028 got merged. cc @liranmauda @baum

liranmauda commented 2 years ago

Hi @nik-redhat This is a purely Downstream issue. We are not supporting Upstream builds for s390x and ppc64le arch.

With that in mind, the issue here is that PR https://github.com/noobaa/noobaa-core/pull/7028 presented a code regression, in the compilation and support for s390x and ppc64le arch.

The code regression is easy to fix, all we need to do is take the latest https://github.com/catid/gf256 files into our codebase under the cm256, and update the version.md

This will fix the regression, then we should run again and see if the container is getting built for s390x and ppc64le arch.

@baum @nimrod-becker @dannyzaken FYI

I am closing this issue, as it is not supported in the upstream, please open a BZ so we can track that on the Downstream.

nik-redhat commented 2 years ago

Ok, when you say Downstream you mean limited to the release-x.y branches, correct?

If so, then the issue is that we are running nightly runs on the master branches too and it is tracked under 4.99 version in downstream and for the time being even 4.12 is taking the latest master code. So, the build for both of them are failing.

Also, as of now we don't have this issue in any of the release branches so not sure how will the bz track it, or the BZ is just a reference (something downstream generic) to fix it for the master branch too?

liranmauda commented 2 years ago

No, Downstream = RedHat builds. Upstream = Community builds. No other branch will be affected, Just 5.12