noobaa / noobaa-core

High-performance S3 application gateway to any backend - file / s3-compatible / multi-clouds / caching / replication ...
https://www.noobaa.io
Apache License 2.0
271 stars 80 forks source link

NC | Unit tests suggestions and refactoring #8056

Open romayalon opened 6 months ago

romayalon commented 6 months ago

Environment info

Unit tests refactoring ideas

  1. CLI validations unit tests - as mentioned in https://github.com/noobaa/noobaa-core/pull/8052#discussion_r1606488761 - currently CLI validations unit tests are scattered in different files, we should have a single unit test file for CLI argument validations.
  2. test_bucketspace.js should be renamed to test_nsfs_integrations.js test_s3_on_nsfs_flow.js or something similar as it is not actually a unit test file but it provides integration tests.
  3. Full RPM/Linux flow tests - install, upgrade, health, syslog.
  4. Metrics tests.
  5. Add more existing s3 tests to nc_index.js (currently commented).
  6. S3 concurrency tests - bucket/objects scale 1000. Concurrent ops example for buckets: create, list, delete.
  7. CLI concurrency tests - bucket/account scale 1000. Concurrent ops example for buckets: create, list, delete, health.
  8. Remove duplicate code - like exec_manage_cli() and other functions used by mocha/jest i different ways.
github-actions[bot] commented 2 months ago

This issue had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed.

romayalon commented 2 months ago

still relevant, commenting so stale bot won't close this issue