search

noobaa / noobaa-operator

Operator for NooBaa - object data service for hybrid and multi cloud environments :cloud: :wrench:
https://www.noobaa.io
Apache License 2.0
103 stars 101 forks source link

Adding disable_cookies annotation to S3 route #1332

Closed jackyalbo closed 7 months ago

jackyalbo commented 7 months ago

Explain the changes

  1. Disable the cookies when using s3 routes as some s3 clients like Cyberduck don't handle them correctly.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed #1327

Testing Instructions:

  1. install a noobaa system on top of OCP cluster
  2. try to connect to the system with default access keys using Cyberduck
  3. see that you can connect and list the buckets and not get issues about bad signature
jackyalbo commented 7 months ago

LGTM, Could you edit the description of this PR and explain the reason?

it's already in the description: "some s3 clients like Cyberduck don't handle them correctly." :) TLDR: Cyberduck