noobaa / noobaa-operator

Operator for NooBaa - object data service for hybrid and multi cloud environments :cloud: :wrench:
https://www.noobaa.io
Apache License 2.0
103 stars 101 forks source link

Updating Rook to v0.0.0-20240327231646-b6b89a012a95 #1348

Closed vh05 closed 7 months ago

vh05 commented 7 months ago

To accommodate the above change we are moving k8s.io/api to 0.29.3 from 0.28.4 which is effectively bringing VolumeResourceRequirements in place of ResourceRequirements

PersistentVolumeClaimSpec had ResourceRequirements in 0.28.4 and here is the github link for the same https://github.com/kubernetes/api/blob/d2d5db7d05d8a0c0dfc5e76035904476a065987c/core/v1/types.go#L489C12-L489C32

and the ResourceRequirements has been replaced by VolumeResourceRequirements in 0.29.3 and the github link is below https://github.com/kubernetes/api/blob/a819b1d9bd169a0584c6d17430450ec1976c17de/core/v1/types.go#L502C12-L502C38

Since the change has happened inside PersistentVolumeClaimSpec in k8s.io/api, we can safely assume that updating to 0.29.3 from 0.28.4 wont break our code.

Few more details:

ResourceRequirements definition in 0.28.4 https://github.com/kubernetes/api/blob/d2d5db7d05d8a0c0dfc5e76035904476a065987c/core/v1/types.go#L2394

VolumeResourceRequirements definition in updated v0.29.3 https://github.com/kubernetes/api/blob/a819b1d9bd169a0584c6d17430450ec1976c17de/core/v1/types.go#L2608

Because of the above explained changes, we are forced to do some code level changes in the above mentioned context