Avoid RPC Printing of `S3AccessKeys` - Githubissues

noobaa / noobaa-operator

Operator for NooBaa - object data service for hybrid and multi cloud environments :cloud: :wrench:

https://www.noobaa.io

Apache License 2.0

102 stars 99 forks source link

Avoid RPC Printing of `S3AccessKeys` #1358

Closed shirady closed 4 months ago

shirady commented 4 months ago

Environment info

CLI version: 5.17.0 noobaa-image: noobaa/noobaa-core:master-20240314 operator-image: noobaa/noobaa-operator:5.17.0

Actual behavior

When performing RPC call using the type S3AccessKeys we can see the strings.

Expected behavior

When performing RPC call using the type S3AccessKeys we will not see the strings.

Steps to reproduce

It was found during code review of PR #1344 (here).

More information - Screenshots / Logs / Other output

Currently we do not hide the secret key and access key that are from type S3AccessKeys like we did for Identity and Secret using type MaskedString (instead of string).