Updated forceMD5Etag to boolean pointer type - Githubissues

noobaa / noobaa-operator

Operator for NooBaa - object data service for hybrid and multi cloud environments :cloud: :wrench:

https://www.noobaa.io

Apache License 2.0

102 stars 99 forks source link

Updated forceMD5Etag to boolean pointer type #1430

Closed achouhan09 closed 5 days ago

achouhan09 commented 3 weeks ago

Explain the changes

Updated forceMd5Etag to a Boolean Pointer Type (bool): The forceMd5Etag flag is now handled as a pointer to a boolean (bool) to explicitly track whether the flag was provided by the user:

If the flag was set, forceMd5Etag points to a true or false value.
If the flag was not set, forceMd5Etag remains nil, preventing unintended changes to the ForceMd5Etag field.

Issues: Fixed #xxx / Gap #xxx

Improvement: #1215
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2312533

Testing Instructions:

Try creating and updating the bucket using cli.
Try creating and updating the NoobaaAccount using cli and yaml both.

jackyalbo commented 2 weeks ago

@achouhan09 I remember @dannyzaken had issues when changing API schemas between versions. Did you test upgrade where there was a noobaaAccount with true/false set and if it worked after moving to the new schema in the later version? Try doing a whole upgrade procedure of running with the old CRD and then changing to the new one and see if everything still works(can maybe check with the cli upgrade command - if it supports upgrading the CRDs)