Minor cross compile issues

noobdoesre / openjpeg

Automatically exported from code.google.com/p/openjpeg

Other

0 stars 0 forks source link

Minor cross compile issues #129

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

I cross compiled openjpeg 1.5.0 on linux for windows, and I had some minor 
issues to overcome.

1. the names of the resulting binaries where prefixed with my cross compiler 
prefix. That is not supposed to happen when you are cross compiling.
I tracked this down to the use of AC_CANONICAL_SYSTEM in configure.ac. Better 
to remove this.

2. When I do not build with JPWL, the install still creates man pages for it.

3. libtiff was not detected correctly, because when cross compiling it is not 
in /usr, /usr/local of /opt/local. Detecting that we should just use $CC -ltiff 
did not work.

Patches for these 3 issuse are attached. I hope you will find them useful.

Original issue reported on code.google.com by h...@hiberis.nl on 22 Feb 2012 at 3:46

Attachments:

GoogleCodeExporter commented 9 years ago

rex can you check those autotools stuff ? Thx

Original comment by mathieu.malaterre on 21 May 2012 at 1:58

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

I generally only do cmake myself, but have apprentice-level auto*-fu.  At first 
glance, 0001 and 0002 patches look good.  0003 is a little more invasive and 
may have side-effects, but the logic behind the change is good too.

Original comment by rdieter@gmail.com on 21 May 2012 at 2:16

GoogleCodeExporter commented 9 years ago

forgot to mention, I'll go ahead and test these out, and commit if nothing 
breaks.

Original comment by rdieter@gmail.com on 21 May 2012 at 2:17

GoogleCodeExporter commented 9 years ago

rex any update ?

Original comment by mathieu.malaterre on 25 Feb 2014 at 4:03

Added labels: Milestone-Release1.5.2

GoogleCodeExporter commented 9 years ago

Sorry, no update yet.  but thanks for the reminder, will redouble efforts this 
week.

Original comment by rdieter@gmail.com on 25 Feb 2014 at 4:17

GoogleCodeExporter commented 9 years ago

And by 'week' you mean 'month' ;-)

Original comment by mathieu.malaterre on 14 Mar 2014 at 3:15

GoogleCodeExporter commented 9 years ago

Changes look good, was trying to commit at least submitted patch 0001 and 0002 
and ran into problems:

svn: E175013: Commit failed (details follow):
svn: E175013: Access to '/svn/!svn/act/1adc6183-884c-460d-ba09-756c93506d6e' 
forbidden

not sure what's up with that.  I'll keep trying.

Original comment by rdieter@gmail.com on 21 Mar 2014 at 7:20

GoogleCodeExporter commented 9 years ago

My mistake ... Rex, could you retry now ?

Original comment by antonin on 24 Mar 2014 at 4:11

GoogleCodeExporter commented 9 years ago

Thanks, all good, all 3 patches committed.

Original comment by rdieter@gmail.com on 24 Mar 2014 at 5:02

Changed state: Fixed