Provide a feature flag for running as presto client - Githubissues

nooberfsh / prusto

A presto/trino client library written in rust.

MIT License

37 stars 23 forks source link

Provide a feature flag for running as presto client #19

Closed cw-kajiwara closed 2 years ago

cw-kajiwara commented 2 years ago

Description

Hi! Thank you for providing such a nice crate! We've used this crate as Presto client by changing header keys into presto ones.

We're thinking it would be great if this upstream prusto crate would provide an option for running as presto client :)

Changes

adding file for declaring presto header
importing trino/presto header file, depending on feature flag
adding feature flag to run prusto as presto client

Checklist

compilation with no feature flag (cargo +nightly build)
compilation with "presto" feature flag enabled (cargo +nightly build --features presto)

I'd like to hear your opinion about this change 🙏

nooberfsh commented 2 years ago

@cw-kajiwara thanks