nooberfsh / prusto

A presto/trino client library written in rust.
MIT License
37 stars 23 forks source link

Model to its own crate #26

Open elferherrera opened 1 year ago

elferherrera commented 1 year ago

Proposal to move Prusto model to its own crate so it could be used by other projects that require to parse trino data but don't require a client

nooberfsh commented 1 year ago

Hi, Thanks for the PR. At first I thought it was only the models are moved to a separate crate, not including the types, currently types are implemented in a very opinioned way and I don't think they are useful for other implementations, so I think the types should keep in the prusto crate. Than I found models are depend on types which is unfortunate. Do you have any ideas about this.

elferherrera commented 1 year ago

I'm slowly getting familiar with trino's response, so I don't know how the data is encoded. What made you select those types?