Avoid jsonifying Buffers for ServiceBus and variants.

noodlefrenzy / node-amqp10

amqp10 is a promise-based, AMQP 1.0 compliant node.js client

MIT License

134 stars 56 forks source link

Avoid jsonifying Buffers for ServiceBus and variants. #235

Closed noodlefrenzy closed 7 years ago

noodlefrenzy commented 8 years ago

Attempted fix for https://github.com/Azure/azure-event-hubs/issues/118

This change is

mbroadst commented 8 years ago

LGTM

ThomasAnnerel commented 8 years ago

Just tried thuis commit. We het followig exception: Unhandled rejection (<{"descriptor":{"buffer":{"type":"Buffe...>, no stack trace)

https://gist.github.com/ThomasAnnerel/548307a92c84e6888b777c131c593c2f

ThomasAnnerel commented 8 years ago

I guys I found another problem in the servicebus policy maxMessageSize: 10000, // Arbitrary choice

If you look at https://azure.microsoft.com/en-us/documentation/articles/service-bus-quotas/ we notice this should be 256 bytes

Kind regards Thomas Annerel

mbroadst commented 8 years ago

@ThomasAnnerel sorry you're still having trouble! I'll defer to @noodlefrenzy on the actual ServiceBus related stuff here, but it looks like you're correct on that constant - would you be willing to put together a PR for that?