search

noodlefrenzy / node-amqp10

amqp10 is a promise-based, AMQP 1.0 compliant node.js client
MIT License
134 stars 56 forks source link

fix(address-parsing): don't truncate ':' passwords #319

Closed dnwe closed 7 years ago

dnwe commented 7 years ago

Fix a bug which truncated passwords containing a ':' character because the parseAddress function relied upon node's url.parse().auth which returns the user:pass pair already URI-decoded.

Fixes #318

This change is Reviewable

mbroadst commented 7 years ago

@dnwe thanks for the contribution, sorry I've been out of town for the past few weeks.

mbroadst commented 7 years ago

@prestona @dnwe looks like this breaks on earlier versions of node, any chance you can update to accommodate that?