search

noodlefrenzy / node-amqp10

amqp10 is a promise-based, AMQP 1.0 compliant node.js client
MIT License
134 stars 56 forks source link

Update .travis.yml #330

Closed oferb1 closed 6 years ago

oferb1 commented 7 years ago

Since v1.36.0 for qpidd, the package fails to build, due to issues with the init.d (see https://issues.apache.org/jira/browse/QPID-7863) As a result travis has been failing As a work around, I have added a basic upstart script, and moved the installation of qpidd and qpid-tools to the before_install section of the travis file

This change is Reviewable

oferb1 commented 7 years ago

Please note that the travis builds now fail due to tests and not because of qpidd

princjef commented 6 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

.travis.yml, line 16 at r1 (raw file):

before_install:
  - npm install -g codeclimate-test-reporter
  - sudo sh -c 'printf "start on (started networking and filesystem)\nstop on runlevel [!2345]\n\nexpect fork\npre-start script\n\tmkdir -p /var/lib/qpidd/\nend script\n\nscript\n\texec qpidd -d --config /etc/qpid/qpidd.conf\nend script\n" > /etc/init/qpidd.conf'

Might be worth adding a comment with a link to the Apache QPID issue for trackinghh

Comments from Reviewable