noodlefrenzy / node-amqp10

amqp10 is a promise-based, AMQP 1.0 compliant node.js client
MIT License
134 stars 56 forks source link

RenewOnSettle policy override is incorrect #333

Open wingedfox opened 6 years ago

wingedfox commented 6 years ago

Hello,

I've found that RenewOnSettle override does no work because provided settings are not used by client. https://github.com/noodlefrenzy/node-amqp10/blob/master/lib/policies/policy_utilities.js#L107 policy provides receiverLink field, but the only place it mentioned and it is not from the overrides https://github.com/noodlefrenzy/node-amqp10/blob/master/lib/amqp_client.js#L289

Either policy or link constructor should be updated to use overrides properly.