noodlefrenzy / node-amqp10

amqp10 is a promise-based, AMQP 1.0 compliant node.js client
MIT License
134 stars 56 forks source link

Extract SASL mechanisms in their own classes #346

Closed pierreca closed 6 years ago

pierreca commented 6 years ago

The ultimate goal of this pull-request is to provide a way for users of the library to create their own SASL mechanisms that would reply to complex challenge/response scenarios.

The first commit only to show the direction I'm suggesting and maybe get some early feedback (I fully intend to write more tests if this direction is approved):

One thing that bothers me is that the SASL objects right now manipulate frames which are believe are not exported from the library - we could change that to only manipulate buffers though, or decide to extract the frame objects.

The last option would be to accept implementation of custom SASL mechanisms in the repository of course.


This change is Reviewable

pierreca commented 6 years ago

newer rearchitected PR coming soon