Closed pierreca closed 6 years ago
Travis is failing for some weird reason in 0.10 version of node.js. Have restarted the ci job. Btw, do we want to support 0.10 or should we remove this from the build matrix?
Otherwise everything LGTM
travis is failing for 0.10 because there are a couple of arrow functions
oops. @pierreca can you replace the arrow functions?
Review status: 0 of 11 files reviewed at latest revision, 6 unresolved discussions.
lib/sasl/sasl.js, line 74 at r1 (raw file):
that's exactly why. I'm not sure we want to start exporting our frames types. It's worth revisiting this decision now though since changing it later would likely be a breaking change.
Done.
lib/sasl/sasl.js, line 91 at r1 (raw file):
any reason for using an arrow function + `self`? i'm guessing this is just a typo and you meant to do `function (responseContent) {` instead (though i'd be all for switching to arrow functions if/when we drop support for old versions of node). same for the `.catch` after this
Done.
lib/sasl/sasl.js, line 69 at r2 (raw file):
i think that's reasonable
Done.
lib/sasl/sasl_anonymous.js, line 19 at r2 (raw file):
same as below
Done.
lib/sasl/sasl_plain.js, line 24 at r2 (raw file):
This is much simpler and does the same thing ```javascript return Promise.resolve(); ```
Done.
Comments from Reviewable
Reviewed 2 of 10 files at r1, 9 of 9 files at r4. Review status: all files reviewed at latest revision, 4 unresolved discussions.
Comments from Reviewable
LGTM
Review status: all files reviewed at latest revision, 4 unresolved discussions.
lib/sasl/sasl.js, line 90 at r4 (raw file):
nit: parentheses shouldn't be necessary
Done.
Comments from Reviewable
This adds the ability to "inject" a SASL mechanism and associated handler in the library, which effectively unlocks the ability to have complex SASL challenge/response exchanges.
registerSaslMechanism
) to enable the user to inject their own sasl handler.This change is