Connection callback is never executed

veselov commented 9 years ago

With this simple code:

var AMQ = require('amqp10');

var amq = new AMQ();

amq.connect('amqp://localhost/hello-world', function(err){
    console.log('connect callback');
    if (err) { throw err; }
 );

console.log('connect scheduled');

function die() {
    setTimeout(die, 1000);
}
die();

the only output is connect scheduled. The strace shows:

socket(PF_INET, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, IPPROTO_IP) = 10
connect(10, {sa_family=AF_INET, sin_port=htons(5672), sin_addr=inet_addr("127.0.0.1")}, 16) = -1 EINPROGRESS (Operation now in progress)
write(10, "AMQP\0\1\0\0", 8) = 8
read(10, "AMQP\1\1\0\n", 65536) = 8
read(10, "", 65536)         = 0
close(10)                   = 0

So, the AMQP conversation ended, and most likely unsuccessfully, but call back was never executed with either success or error.

For info, this is trying against qpidd. node v0.10.32 amqp10 1.0.2

noodlefrenzy commented 9 years ago

Hey, sorry for the lag in getting to this issue - I have the flu and I'm a bit out of it. This definitely looks like an invalid response from qpidd, but as you said at the very least I should be calling the callback with an error in that case.

Have you tried running with your DEBUG env var set to "amqp10-*"? That should output all of the details from my library as to what it's trying to do.

In the meantime, I'll see if I can't repro this on my end - sorry I'll be a bit slow due to the flu.

veselov commented 9 years ago

No rush :) You are right - the reason the library can't connect is legitimate. But callback is not called. I played around with this, and it seems that callback is not called for simpler problems as well.

broker isn't even running:

[vps@druid]~/ws/EF/qpids$ DEBUG=amqp10-Connection  node publish.js 
  amqp10-Connection Connecting to localhost:5672 via straight-up sockets +0ms
  amqp10-Connection Transitioning from DISCONNECTED to START due to connect +2ms
connect scheduled
  amqp10-Connection Error from socket: Error: connect ECONNREFUSED +3ms
  amqp10-Connection Transitioning from START to DISCONNECTED due to error +1ms

broker reports unsupported version:

[vps@druid]~/ws/EF/qpids$ DEBUG=amqp10-Connection  node publish.js 
  amqp10-Connection Connecting to localhost:5672 via straight-up sockets +0ms
  amqp10-Connection Transitioning from DISCONNECTED to START due to connect +2ms
connect scheduled
  amqp10-Connection Sending Header 414d515000010000 +2ms
  amqp10-Connection Transitioning from START to HDR_SENT due to connected +0ms
  amqp10-Connection Rx: 414d51500101000a +1ms
  amqp10-Connection Server AMQP Version: 414d51500101000a vs 414d515000010000 +0ms
  amqp10-Connection Transitioning from HDR_SENT to DISCONNECTING due to invalidVersion +1ms
  amqp10-Connection Transitioning from DISCONNECTING to DISCONNECTED due to terminated +1ms

noodlefrenzy commented 9 years ago

I was failing to trigger an error event on certain cases in connection.js (probably more information than you wanted). I've just published an update (1.0.3) - let me know if that solves your issue.

noodlefrenzy commented 9 years ago

Closing. Feel free to reopen if I didn't actually fix it, but I believe I have.

veselov commented 9 years ago

Thank you! Works fine for me in 1.0.3 :+1: Sorry it took me a while to check this out.