noodlylight / fusilli

X Window Manager (Compiz fork)
Other
25 stars 5 forks source link

wall plugin shouldn't react on mouse scrolling #20

Closed raveit65 closed 9 years ago

raveit65 commented 9 years ago

For some reasons mouse srolling switch the viewport, which ends up in an unfinished action if next viewport has a maximize window. Here mouse srolling from wall plugin stoped working because of the maximize window. In result the viewport is unusable and you see only the previews of the wall plugin. Switching back with a keyboard command to another viewport helps at that point. I'm still wondering why switching a viewport is possible with mouse scrolling, i didn't find any setting for that in fsm, but maybe i miss something. Also i never saw this behaviour with compiz.

raveit65 commented 9 years ago

Ok, i found the culprit. After i removed the mouse commands 'ClickOnDesktop + Button4' and 'ClickOnDesktop + Button5' in wall plugin settings, the issue is gone. Curiously i use a 3 button mouse, not a 5 button mouse. I think both keys shouldn't enabled as default, imo, because a fusilli beginner can be going crazy about :) But it's up to you to decide if it's an issue or not. Also, this settings aren't default in my compiz version. I included the wall plugin with a patch to compiz main package, ( before it was in in compiz-plugins-main). http://pkgs.fedoraproject.org/cgit/compiz.git/tree/compiz-0.8.6-wall.patch Looks like this patch has other defaults than the wall plugin from compiz-plugins-main.

noodlylight commented 9 years ago

Yes, tag ClickOnDesktop is new. (not possible in compiz)

In Compiz, changing workspaces with the wheel was accomplished using a plugin (vpswitch).

Related commit: https://github.com/noodlylight/fusilli/commit/3163a206c243c8777667bd4b00dfbf46ef2657aa

noodlylight commented 9 years ago

I think both keys shouldn't enabled as default, imo, because a fusilli beginner can be going crazy about :) But it's up to you to decide if it's an issue or not.

It is probably a good idea.

I want to first add support for large texts in fsm (to note how to enable this behavior) and then I'll remove the related default bindings in rotate and wall.

raveit65 commented 9 years ago

I want to first add support for large texts in fsm (to note how to enable this behavior) and then I'll remove the related default bindings in rotate and wall.

nice, adding more infos for users sounds like a good idea .

In Compiz, changing workspaces with the wheel was accomplished using a plugin (vpswitch).

Related commit: 3163a20

I'm only wondering why button 4/5 is the srollwheel with a 3 button mouse.

noodlylight commented 9 years ago

I'm only wondering why button 4/5 is the srollwheel with a 3 button mouse.

It's X11 terminology. :)

More: http://stackoverflow.com/questions/15510472/scrollwheel-event-in-x11