noodlylight / fusilli

X Window Manager (Compiz fork)
Other
25 stars 5 forks source link

add viewport switcher #3

Closed hiempsal closed 10 years ago

hiempsal commented 10 years ago

http://www.hostingpics.net/viewer.php?id=347168Capture5.png

noodlylight commented 10 years ago

Hello!

I just added support for modifier ClickOnDesktop. When set on a button binding, the binding is triggered only when clicked on the desktop.

For example, setting

rotate_left_button=<ClickOnDesktop>Button4
rotate_right_button=<ClickOnDesktop>Button5 

enables switching viewports by scrolling on the desktop. (I set those settings as default).

This change simulates the major functionality offered by plugin vpswitch, since the "go-to-specific-viewport" button bindings are duplicated in the rotate plugin. Do you think there is anything missing?

EDIT: added code fencing around options, since github didn't display it correctly.

ShadowKyogre commented 10 years ago

Just tested it in my virtual machine! It looks like the new modifier isn't working properly. However, I do like the fact that it's now a modifier, meaning /every/ plugin that has button bindings greatly benefits from this.

My banana.xml from the machine: http://dpaste.com/2FTK3WK

On 11/19/2014 10:27 AM, Michail Bitzes wrote:

Hello!

I just added support for modifier . When set on a button binding, the binding is triggered only when clicked on the desktop.

For example, setting rotate_left_button=Button4 and rotate_right_button=Button5 enables switching viewports by scrolling on the desktop. (I set those settings as default).

This change simulates the major functionality offered by plugin vpswitch, since the "go-to-specific-viewport" button bindings are duplicated in the rotate plugin. Do you think there is anything missing?

— Reply to this email directly or view it on GitHub https://github.com/noodlylight/fusilli/issues/3#issuecomment-63688249.

hiempsal commented 10 years ago

hi @ShadowKyogre @noodlylight the rotate button left and right work, but rotate botton (old compiz) not work My banana.xml from the machine: http://dpaste.com/2YPSCSZ

noodlylight commented 10 years ago

Thanks for your banana.xml!

I'm not 100% sure about your request: do you want to spin the cube by middle-clicking on the desktop?

If so, go FSM->rotate->Bindings->Initiate and set it to:

<ClickOnDesktop>Button2
hiempsal commented 10 years ago

@noodlylight ClickOnDesktop Button2 it work :+1:

noodlylight commented 10 years ago

@hiempsal Great :+1:

It's time to close this issue, the requested functionality was implemented.

Relevant commits for reference:

3163a206c243c8777667bd4b00dfbf46ef2657aa 2b66aace2535e15dea8a6ec71fd0f210b809a35a