search

noonereally / NW-Profession-Bot

Automatically selects professions for empty slots
4 stars 1 forks source link

Translation should really work now #44

Closed WloBeb closed 9 years ago

WloBeb commented 9 years ago

@noonereally I have one little questions: Why most of your commits have no description? Eg. have only description "Update main.js"

GeneralSheppard commented 9 years ago

Thank you for this. As soon as I get home I start working on it.

noonereally commented 9 years ago

The "Update main.js" is the default, so some are minor fixes, from css change to minor bug, like for example that missing vendorPots5 (there is another one missing, that I will commit soon). Others i just forget and commit. I'll try to be more descriptive in the future.

With the translation function needs the setting, can I just put the setting loading higher ? And the translation call after it. And maybe only read do GM_getValue only if !scriptSettngs. Just a though, I'm scared of those GM_loads.

btw, where is the "+" I went over your branches and can't find it. I want to add custom/private profiles tab and wanted to merge that idea.. with an option to import profiles and save into the GM_setValue. -- I know it was long ago, yet I was busy and didn't have the time, also to be honest at a glance I'm not sure 100% how both the functions work exactly so merging it in a good way will take digging and testing so I delayed it.

WloBeb commented 9 years ago

You really didn't use local git repository on your computer???

With regards to reading scriptSettings. Just look at code. When you read settings, you merge it with setting object, which includes names displayed on interface, witch should be translated, witch needs language variable from stored settings..... insane circle. The only solution that came to my mind, is a self-reading of script setting object (only once). Another idea is redundant GM_ variable that stores only language.

BTW. Do you know, that enable/disable debug doesn't work? Everything is always logged on real console. Probably "onsave" part doesn't work.

"+" is in my list idea branch. But this branch is really obsolete. I have yet another idea, never implemented.

    function createNextTask(prof, i, level) {

if 'level' === undefined get profession level of current character (as now) and inside:

        if (list.length <= i) {
            console.log("Nothing Found");
            switchChar();
            return false;
            createNextTask(prof, 0, level-1);
        }
noonereally commented 9 years ago

No, I just paste and commit here.

Things in the settings object never displayed to the user. The displayed part is at settingsUI array. And the actual display part is at the bottom of the execution, at process()

Yes, thanks, there is a unsafewindow.console = console hard coded line for now, the onsave thing is problematic.

Need to look at the code.