search

noony / prometheus-solr-exporter

Solr exporter for prometheus.
Apache License 2.0
27 stars 18 forks source link

Make exporter solr 6 compatible #6

Closed bjoernhaeuser closed 7 years ago

bjoernhaeuser commented 7 years ago

Not sure if this still works with solr 5 :(

AFAICS handlers without a "/" prefix will never have a query time.

noony commented 7 years ago

Hi, sorry I'm a little bit late. I'm reviewing your pr tonight. Thanks !

noony commented 7 years ago

This PR need little improvements to be compliant with solr4/5/6

bjoernhaeuser commented 7 years ago

Hm, can you be a little more specific? :) Is this something we want to do or should we focus only on one version? Or do we need different exporters, depending on the version?

bjoernhaeuser commented 7 years ago

Rebased onto current master.

fabriziofortino commented 7 years ago

+1

noony commented 7 years ago

hi @bjoernhaeuser, sorry for my late response.

I tested with this docker image : docker run -p 8983:8983 -d -P solr:6.6.1 solr-precreate mycore

and then launching ./solr_exporter And I didn't had errors.

bjoernhaeuser commented 7 years ago

Without or with the patch?

You do not see any kind of errors, the data is simply missing.

noony commented 7 years ago

New release is now available with full compatibility solr 5/6. I'm pushing a new release now.

fabriziofortino commented 7 years ago

Thanks @bjoernhaeuser / @noony . Great stuff! One question: I have seen a lot of changes around metrics in Solr 6. Does this work with all the 6.x version?

noony commented 7 years ago

Done : https://hub.docker.com/r/noony/prometheus-solr-exporter/tags/

Can you test please ?

@fabriziofortino I don't know but normally it's ok.