Closed bjoernhaeuser closed 7 years ago
Hi, sorry I'm a little bit late. I'm reviewing your pr tonight. Thanks !
This PR need little improvements to be compliant with solr4/5/6
Hm, can you be a little more specific? :) Is this something we want to do or should we focus only on one version? Or do we need different exporters, depending on the version?
Rebased onto current master.
+1
hi @bjoernhaeuser, sorry for my late response.
I tested with this docker image : docker run -p 8983:8983 -d -P solr:6.6.1 solr-precreate mycore
and then launching ./solr_exporter And I didn't had errors.
Without or with the patch?
You do not see any kind of errors, the data is simply missing.
New release is now available with full compatibility solr 5/6. I'm pushing a new release now.
Thanks @bjoernhaeuser / @noony . Great stuff! One question: I have seen a lot of changes around metrics in Solr 6. Does this work with all the 6.x version?
Done : https://hub.docker.com/r/noony/prometheus-solr-exporter/tags/
Can you test please ?
@fabriziofortino I don't know but normally it's ok.
Not sure if this still works with solr 5 :(
AFAICS handlers without a "/" prefix will never have a query time.