Various WebVTT timecode formats support, maxDuration parameter, stream API

noophq / subtitle

Convert subtitles from one format to another format. Supported formats: STL EBU, TTML SMI, VTT, SRT

GNU Lesser General Public License v3.0

100 stars 40 forks source link

Various WebVTT timecode formats support, maxDuration parameter, stream API #4

Closed soualid closed 7 years ago

soualid commented 7 years ago

From MarieTenegal's fork (which added offset support).

Added support for all VTT timecode formats (mm:ss.ms and h:mm:ss.ms)
Improved offset support for VTT to ignore subtitles when offset is negative
Added stream support to the convert API (to be able to use the API outside a CLI in plain Java)
Added a maxDuration parameter to implement a "trim subtitle" feature (only supported with VTT for now since it was our need)

soualid commented 7 years ago

I think we should extrapolate the subtitle transforms (offset and trim) inside dedicated and pluggable transformers. I will take some time to design this as soon as I find free time to do so, consider the actual PR as a quick & dirty implementation. :-)

clebeaupin commented 7 years ago

Could you resolve the conflicts and try to pull the request on feature/experimental branch

soualid commented 7 years ago

Sure !