noopkat / avrgirl-arduino

:girl: :pager: A NodeJS library for flashing compiled sketch files to Arduino microcontroller boards.
MIT License
506 stars 129 forks source link

Remove gulp #179

Closed knitcodemonkey closed 5 years ago

knitcodemonkey commented 5 years ago

Description

Attempts to replace outdated gulp-tape plugin that prevents contributors from using JSX syntax.

This is a breaking change because eslint doesn't support node 6 and below.

Fixes/addresses #178

Type of change

Checklist:

Test / Development Platform Information

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.3%) to 44.211% when pulling ac8873489bbdf9f7ba87ea9ba3f8b25136f2c5ed on knitcodemonkey:remove-gulp into 1dfd9c12f12a3076ad131199952e23543f15e9fd on noopkat:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.3%) to 44.211% when pulling 7d557d71165460984a03f00403e2eaab1aeb1508 on knitcodemonkey:remove-gulp into 1dfd9c12f12a3076ad131199952e23543f15e9fd on noopkat:master.

noopkat commented 5 years ago

this is really good thank you! I looked at the current NodeJS support timelines and NodeJS versions 6 & 7 are ~not~ now end of life, so I think we can go ahead and:

  1. remove them from our travis yaml config
  2. bump the next version of avrgirl-arduino to a major release with these changes in it

I'll test with physical hardware before merging this but it should all be fine 🌈

Thanks again for bringing this library into the present day after being stuck in the past.

knitcodemonkey commented 5 years ago

Thank you for looking at this PR, @noopkat. I have removed node 6 and 7 from the yaml file, and bumped the version to 4.0.0. Even if this doesn't bring you all the way up to date, it certainly makes the last of the updates easier!

noopkat commented 5 years ago

hey @knitcodemonkey this doesn't look like it's going to merge properly as far as Github is concerned but thank you for much for removing gulp and leveling up our test and linting framework!

bitmoji