noopkat / avrgirl-arduino

:girl: :pager: A NodeJS library for flashing compiled sketch files to Arduino microcontroller boards.
MIT License
506 stars 129 forks source link

baudrate is now baudRate #209

Closed monteslu closed 4 years ago

monteslu commented 4 years ago

Description

Please review the contribution and code of conduct guidelines.

Was trying to flash a board with the web example and noticed errors because of this change: https://reillyeon.github.io/serial/#dom-serialoptions-baudrate baudrate is now baudRate

Still need to do a bit of debugging on setSignals, but one step at a time :)

Type of change

Please delete options that are not relevant.

Checklist:

Test / Development Platform Information

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 46.98% when pulling 7fd21cd6853a5113e3241184b7e1b8a052b9c947 on monteslu:baudRate into f4ee1160fb4eb4f395fc6226e259b18166edf09a on noopkat:master.

noopkat commented 4 years ago

thank you 🙇