noopkat / avrgirl-arduino

:girl: :pager: A NodeJS library for flashing compiled sketch files to Arduino microcontroller boards.
MIT License
506 stars 129 forks source link

Update SerialPort to v10, fixing several breaking changes. I need a hand with tests. #255

Open obra opened 2 years ago

obra commented 2 years ago

IMPORTANT: This doesn't currently pass tests due to how SerialPort.list gets mocked. I'm having a hard time understanding the correct way to fix the mocking library.

SerialPort 10 is dramatically easier for Electron apps to bundle. I'd really love to get avrgirl-arduino updated to work with it.

Manual testing seems to indicate that the changes work, including the behaviour that's failing tests. It looks like there's a dep issue with avrga-tester that's blocking my ability to run through the test-pilot process. I'm really sorry about that :/

image

Signed-off-by: Jesse Vincent jesse@keyboard.io

Description

Please review the contribution and code of conduct guidelines.

Please include a summary of the proposed improvement or addressed issue.

Fixes/addresses (If applicable) # (issue)

Type of change

Please delete options that are not relevant.

Checklist:

Test / Development Platform Information

obra commented 2 years ago

@noopkat this is as much a request for feedback as anything else. When you have the time, I'd love to know whether this is something to push on or not.