search

noopkat / avrgirl-usbtinyisp

AVRGirl wrapper for driving USBtinyISP programmers
13 stars 5 forks source link

Set node engine to 7.6 and refactor to use ES6 class and lambda syntax #15

Closed spoon16 closed 6 years ago

spoon16 commented 6 years ago

I threw this together while I was waiting for a new environment to come up in AWS because I heard you say you were interesting in people helping you move your repositories to more modern JS syntax/patterns. This does break backwards compatibility with some old versions of node. You could probably fix that with webpack/babel if maintaining that compatibility is important.

Set minimum node version in package.json to support ES6 features. Refactored avrgirlUsbTinyIsp to be an ES6 class. Refactored most the the callbacks to use lambda syntax. Refactored some string concatenation to use template literals.

This diff is a bit gross because of the refactor to ES6 class syntax. Feel free to reject if that's frustrating.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-4.9%) to 51.064% when pulling 3db76a92692e6fac27bebf5ab3003d7a5159a724 on spoon16:master into d670f723d1d026fa304a04bd2dd7d99e7c951098 on noopkat:master.

noopkat commented 6 years ago

hi @spoon16!

Sorry this took an extra week to get to. I went ahead and installed babel and am transpiling for compatibility with Node v4/5.

Thanks for an excellent PR ✨ I'm merging and publishing this along with the babel work.

bitmoji

spoon16 commented 6 years ago

I did not expect you to merge. Thanks!