noopkat / avrgirl-usbtinyisp

AVRGirl wrapper for driving USBtinyISP programmers
13 stars 5 forks source link

Updating all dependencies #18

Closed kleinfreund closed 5 years ago

kleinfreund commented 5 years ago

Hey there Suz,

this pull request updates all dependencies. All tests pass; however, I do not work with any hardware so I can’t test test this for real.

I also updated the readme to include a message on installing this library on Linux. It was breaking on my system due to a failing native build. The following is just an excerpt of the error output:

node-pre-gyp WARN Using needle for node-pre-gyp https download 
node-pre-gyp WARN Tried to download(404): https://github.com/tessel/node-usb/releases/download/1.5.0/usb_bindings-v1.5.0-node-v67-linux-x64.tar.gz 
node-pre-gyp WARN Pre-built binaries not found for usb@1.5.0 and node@11.6.0 (node-v67 ABI, glibc) (falling back to source compile with node-gyp) 
make: Entering directory '/home/phil/dev/repos/usbtinyisp/node_modules/usb/build'
...
../libusb/libusb/os/linux_udev.c:40:10: fatal error: libudev.h: No such file or directory
 #include <libudev.h>

I also replaced one tiny apostrophe with a typographical version so that the JavaScript syntax highlighter won’t show an invalid syntax in the readme.

Until Sunday.

P.S.: Should this be reviewed on stream: Heya #noopkrew :love_letter:.

kleinfreund commented 5 years ago

Ah, Travis got my back. This fails in Node 4.

noopkat commented 5 years ago

Hi @kleinfreund! Thanks HEAPS for doing this chore on the repo. I tweaked the travis config to retire Node 4 and 5, so could you please pull in the latest on the master branch to see if this resolves the issue? Thanks again! 🙇‍♀️

kleinfreund commented 5 years ago

@noopkat Rebased and force-pushed to trigger a new Travis build; it’s looking all good now. :balloon:

noopkat commented 5 years ago

thanks for updating the branch! Merging now ✨

image