Cards cannot be dismissed

rhianvanesch commented 5 years ago

I get the following error when trying to dismiss a card (by clicking the X):

DOMException: Failed to execute 'showModal' on 'HTMLDialogElement': The element is not in a Document.
    at t.show (http://localhost:3000/js/dist/vendors~main.bundle.js:14:260550)
    at openCardDeleteModal (http://localhost:3000/js/dist/main.bundle.js:1:18476)
    at click (http://localhost:3000/js/dist/main.bundle.js:1:6439)
    at $e (http://localhost:3000/js/dist/vendors~main.bundle.js:7:11091)
    at HTMLButtonElement.n (http://localhost:3000/js/dist/vendors~main.bundle.js:7:12796)
    at HTMLButtonElement.i._wrapper (http://localhost:3000/js/dist/vendors~main.bundle.js:7:47334)

Possibly related to this issue on vue-a11y-dialog: https://github.com/morkro/vue-a11y-dialog/issues/8

rhianvanesch commented 5 years ago

Update: it does work on the Cool Button card in my dashboard (which is copied from the default dashboard) - but on no other card, so I think it's likely to be caused by the issue I linked above.

rhianvanesch commented 5 years ago

Note: this seems to be fixed by updating vue-a11y-dialog as in @kleinfreund 's latest PR #111.

kleinfreund commented 5 years ago

Ah, I wondered if that would auto-magically fix it. We got lucky. :)

noopkat commented 5 years ago

thanks @escherina for reporting this 💯 thanks @kleinfreund for fixing this with your diligent dependency updating! 🥇

bitmoji

noopkat / electric-io

Cards cannot be dismissed #110