String.Empty bug URL during plugin HttpClient load & multiple shipment offerings not getting filtered out

nopSolutions / USPS-plugin-for-nopcommerce

Shipping plugin for USPS

https://www.nopcommerce.com/

GNU General Public License v3.0

2 stars 8 forks source link

String.Empty bug URL during plugin HttpClient load & multiple shipment offerings not getting filtered out #4

Closed mitcht closed 4 years ago

mitcht commented 4 years ago

It is possible for uspsSettings.Url to be an empty string if settings are saved and the URL field is left blank, but the username and password are set. This breaks the plugin load.

mitcht commented 4 years ago

Updated pull req title.

exileDev commented 4 years ago

Thanks a lot! We've already completed this task, see the commit 3b994b8144e78417ff64c49b79f27e1349354761