nopSolutions / nopCommerce

ASP.NET Core eCommerce software. nopCommerce is a free and open-source shopping cart.
https://www.nopcommerce.com
Other
9.27k stars 5.32k forks source link

Review the use of events in the NewsLetterSubscription service #5300

Closed RomanovM closed 3 years ago

RomanovM commented 3 years ago

nopCommerce version: develop

We moved the generic events publishing from services to the repository, but for some reason left for the above service. We also have a separate EmailSubscribedEvent and EmailUnsubscribedEvent events for this. This all leads to duplicate events and the impossibility of using them correctly in plugins. So, let's check and review using all of these events in the service.

Source: https://www.nopcommerce.com/en/boards/topic/90037/handleevententityinsertedeventnewslettersubscription-eventmessage-gets-called-twice

skoshelev commented 3 years ago

Closed #5300