search

nopSolutions / nopCommerce

ASP.NET Core eCommerce software. nopCommerce is a free and open-source shopping cart.
https://www.nopcommerce.com
Other
9.19k stars 5.28k forks source link

Can't disable add to wishlist button from settings #6832

Closed curllog closed 1 year ago

curllog commented 1 year ago

image

nopCommerce version: 4.60 - current github version

Steps to reproduce the problem: Go to Settings and find producteditorsettings.disablewishlistbutton make it true and save

clear cache and open frontend and nothing will be change

probelm: By mistake nopcommerce reads value for DisableWishlistButton from product table !!!

image

You know when we updating settings it will change values in other table

I think we need 2 pull request first for fixing this bug so nopcommerce will read this settings from catalogsettings second remove this column from entity and producteditorsettings.disablewishlistbutton from everwhere

I have pull request for first step i don't know about backward compability so inform me if i can make other pull request and delete disablewishlistbutton stuff

https://github.com/nopSolutions/nopCommerce/pull/6833

Please Review This and inform me with any problems

AndreiMaz commented 1 year ago

@MohammadAnsari98 Everything works fine. "producteditorsettings" is not related to the public store, it's used to manage this setting visibility in admin area.