search

nopSolutions / nopCommerce

ASP.NET Core eCommerce software. nopCommerce is a free and open-source shopping cart.
https://www.nopcommerce.com
Other
9.14k stars 5.25k forks source link

QueryProcAsync and ExecuteNonQueryAsync doesn't close connection to DB #7118

Closed aljaz00 closed 5 months ago

aljaz00 commented 5 months ago

nopCommerce version: 4.60.2 using MSSQL as DB

When using await _nopDataProvider.QueryProcAsync<T> connections are not closed. It's the same with using await _nopDataProvider.ExecuteNonQueryAsync<T>.

I think the problem is with method CreateDbCommand, it's not disposing connection as it should.

exileDev commented 5 months ago

Closed #7118