search

nopara73 / HBitcoin

Privacy focused Bitcoin library on top of NBitcoin for .NET Core.
MIT License
25 stars 11 forks source link

PR for HBitcoin #1

Closed bokobza closed 7 years ago

bokobza commented 7 years ago

Not many changes at all, although it looks like a lot in Github diff.

nopara73 commented 7 years ago

Thanks. I'll review it later. I changed like a 1000 lines of unsynced changes already:)

bokobza commented 7 years ago

ahah ok, no problem. When you sync your changes, I'll review my changes and resubmit if you want.

nopara73 commented 7 years ago

I pushed my commits. I think I'm finally approaching good stability in syncing with this one.
There is a new test, called RealHistoryTest, it is not a complete test yet, it does not give me the awaited results (in fact the awaited results are not even added yet), that's what I am working on, but I'm pretty sure I just have to modify one small (but complicated) part of the code to get the right results, so it is unlikely we'll have conflicts in the coming 1-2 days. After you resolve the conflicts I review your PR.