nophead / NopSCADlib

Library of parts modelled in OpenSCAD and a framework for making projects
GNU General Public License v3.0
1.22k stars 160 forks source link

Allow configuration of teardrop angle. #211

Closed martinbudden closed 2 years ago

martinbudden commented 2 years ago

In most cases a teardrop angle of 45 degrees is fine, but there are cases when this does not give sufficient overlap between layers and a slightly steeper teardrop angle, say 50 or 55 degrees is desirable. This change allows this.

The teardrop angle is defaulted to its current value of 45 degrees.

In particular I print mostly functional parts and for these (for both strength and speed of printing) I tend to use a 0.6mm nozzle with 0.5mm layer height and 1.0mm extrusion width. For these large layers, a teardrop angle of 50 or 55 degrees gives better results.

nophead commented 2 years ago

I normally merge using the command lines provided by the PR. It worked yesterday but I don't see any today on the remaining PRs. Even the PSU one I am part way through merging.

martinbudden commented 2 years ago

I'm not sure what you mean - is there some kind of problem with github?

nophead commented 2 years ago

Yes either GitHub has changed overnight or I have gone blind

On Tue, 14 Dec 2021, 12:15 Martin Budden, @.***> wrote:

I'm not sure what you mean - is there some kind of problem with github?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nophead/NopSCADlib/pull/211#issuecomment-993481271, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEKHBNNMEZGD2R4TEW23H3UQ4YMVANCNFSM5J22FUTQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

nophead commented 2 years ago

With a diagram I worked out x is simply tan(teardrop_angle /2) and Wolfram says that is equivalent:

image

So the top of the teardrop is 2 R tan(a/2), where have I seen that before today, LOL!

I will simplify it when I merge. It's a pain now Github doesn't give the commands anymore. I have to type them all manually.