search

nophead / NopSCADlib

Library of parts modelled in OpenSCAD and a framework for making projects
GNU General Public License v3.0
1.17k stars 155 forks source link

Should polyholes and teardrops be in core? #233

Closed martinbudden closed 8 months ago

martinbudden commented 2 years ago

Currently polyholes.scad and teardrops.scad are included in utils/global.scad which is included in utils/core.scad.

I don't think polyholes and teardrops are core - they are only used in printed objects, not vitamins.

I think test have shown that the parsing of include files does have an impact on build times, so I think these two files should be move out of core.

Thoughts?

nophead commented 2 years ago

Are they not used rather than included?

martinbudden commented 2 years ago

No, they are included.

nophead commented 2 years ago

That is because global.scad is only used. So all the includes in it get pasted together, parsed once and cached as one entry in the module cache.

nophead commented 2 years ago

I am minded to close this as I don't think parsing these two files once per build is significant and they are probably used in some vitamins that have modules to make mounting holes for themselves.